Skip to content

TYP: read_csv and read_excel fixes #55410

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 5, 2023
Merged

TYP: read_csv and read_excel fixes #55410

merged 1 commit into from
Oct 5, 2023

Conversation

twoertwein
Copy link
Member

@twoertwein twoertwein commented Oct 5, 2023 •
edited
Loading

read_csv's date_format accepts dicts
read_excel's names can be a Sequence with any Hashable types inside

edit: should probably enable type-checking of some tests (def test_xxx(...) -> None should be enough for mypy to check what is happening inside the function)

@twoertwein twoertwein requested a review from rhshadrach as a code owner October 5, 2023 02:11
@twoertwein twoertwein added the Typing type annotations, mypy/pyright type checking label Oct 5, 2023
@mroeschke mroeschke added this to the 2.2 milestone Oct 5, 2023
@mroeschke mroeschke merged commit 940a1b4 into pandas-dev:main Oct 5, 2023
@mroeschke
Copy link
Member

Thanks @twoertwein

@twoertwein twoertwein deleted the types branch December 10, 2023 04:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mroeschke mroeschke mroeschke approved these changes

@rhshadrach rhshadrach Awaiting requested review from rhshadrach rhshadrach is a code owner

Assignees
No one assigned
Labels
Typing type annotations, mypy/pyright type checking
Projects
None yet
Milestone
2.2
Development

Successfully merging this pull request may close these issues.
2 participants
@twoertwein @mroeschke